nikic / PHP-Parser / 37275102599

93%

push

github

Fix integer key renumbering in constant array unpacking (#1174)

`ConstExprEvaluator` uses `array_merge()` for array unpacking, which
renumbers existing integer keys:

```php
$expr = $parser->parse('<?php [5 => "a", ...[1, 2]];')[0]->expr;
$evaluator->evaluateDirectly($expr);
// Before: [0 => "a", 1 => 1, 2 => 2]
// After:  [5 => "a", 6 => 1, 7 => 2]
```

Append unpacked integer-keyed values and assign string-keyed values
directly, preserving existing keys and matching PHP's behavior. Even an
empty unpack (`[5 => "a", ...[]]`) now preserves key `5`.

7 of 7 new or added lines in 1 file covered. (100.0%)

7786 of 8380 relevant lines covered (92.91%)

232.63 hits per line