aio-libs / multidict / 37228402123

86%

push

github

Set up the module's strings and types from tables (#1679)

<!-- Thank you for your contribution! -->

## What do these changes do?

`module_exec()` in the C extension repeated one block per interned
string (six), per created mapping type (four) and per registered type
(eight). This replaces them with:

- a table of `{offsetof(mod_state, field), text}` walked by one loop for
the strings;
- `_multidict_new_type()`, which creates a mapping type and, before
3.14, sets its `tp_vectorcall`. It passes the base class to
`PyType_FromModuleAndSpec()` directly, which accepts a single class, so
the temporary tuple and the `fail:` label that existed to release it are
gone;
- an array of the types to register, walked by one loop.

No behaviour change. The pure-Python implementation is not affected.

## Are there changes in behavior for the user?

No. Only module initialisation is touched; all rows of
`benchmarks/callgrind_driver.py --include-multidict-only` are identical
before and after on 3.14.7 and 3.14.7t, for `MultiDict` and
`CIMultiDict`. The `.text` section shrinks by 96 bytes on 3.14 and 288
bytes on 3.14t.

## Is it a substantial burden for the maintainers to support this?

No; it removes about 25 lines.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [x] Unit tests for the changes exist (the existing suite; every test
imports the module)
- [x] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Fable 5.1); not yet reviewed by a
human.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Measured against 43d41577.

- `tools/check_inlining.py` on 3.14.7 and 3.14.7t: ok
- C extension: 3.14.7 4085 passed, 3.14.7t 4070 passed, 3.10.17 ... (continued)

792 of 1584 branches covered (50.0%)

Branch coverage included in aggregate %.

9330 of 10194 relevant lines covered (91.52%)

1.83 hits per line