Eyevinn / hi265 / 37220784774

81%

Build Type

push

github

Committed by tobbee

Commit Message

perf: read with mp4ff's slice readers and stop copying samples in hi265-mp4-extend

The decoder's own slice header parser now reads through bits.NewEBSPReaderFromSlice instead of an EBSPReader over a bytes.Reader, which allocated for each slice segment.

hi265-mp4-extend parses its segments with DecodeFileSR instead of DecodeFile over a bytes.Reader, collects the input samples with AppendFullSamples instead of one GetFullSamples slice per fragment, and adds them to the output fragment with AddFullSamples. AddFullSample appended every sample to the mdat, so the whole input payload was copied once more; AddFullSamples refers to it. The input samples are views of the parsed input segment, which nothing changes before the fragment is written: the Annex B copy that LastFrameState reads is made from copies of the samples.

The extended segment is byte-identical to the one written before this change in all four modes (freeze, -gray-idr, -gray-cra, -timecode).

Coverage Stats

7 of 7 new or added lines in 2 files covered. (100.0%)

20 existing lines in 1 file now uncovered.

7099 of 8844 relevant lines covered (80.27%)

0.92 hits per line