solidjs / solid / 37214652476

76%

main: 89%

push

github

signals: benchmarks measure the built package; the fold queue's pre-batch record (CodSpeed follow-up to #3774) (#3776)

* bench(signals): benchmarks measure the built package

In benchmark mode the benches' src/index.js import is aliased to the dist
entry of the selected tier (SIGNALS_TIER, default prod for benchmarks) and
the dist is externalized so Node links it natively — the prod build
preserves modules, and vite-node's SSR transform would turn its
cross-module imports back into the namespace-object property loads the
alias exists to take out of the measurement. SIGNALS_BENCH=source keeps a
from-source loop for local iteration. A missing or stale dist fails the
run with the rebuild instruction instead of timing code not under test.

CodSpeed already builds before benching; its first run after this
re-baselines every signals bench. Plan sec. 43.1.

Co-authored-by: Cursor <cursoragent@cursor.com>

* store: the fold queue records the pre-batch backing beside the target

The weak map keyed by target kept every container's last adopted-away
backing alive until its next adoption: for a keyed reconcile the previous
tick's whole tree promoted out of the nursery every tick (saturated
listened-paths +15%, reconcile tree +10-13% over next on the dist, all of
it GC); for a store adopted once, the old tree for the store's lifetime.

The record is now foldOlds, parallel to foldList: t.v at queueFold for
every queued target, released with the drain. That one record is the
fold's base in every case (draft, eager adoption, mid-batch privatization,
draft over an adopted raw), so privatizedOlds, draftedAdoptions and the
adoption flag go. The target has no slot for it (ARRAY SHAPE RULE), so the
by-target lookups (preBatch: a node born onto an open staging, a
committed-frame read of a node-less staging, a park) index the list
through a map built on first use per batch; the drain never builds it.

After, on the dist vs next: tree reverse +3%, shuffle +4%, saturated
+1.... (continued)

649 of 925 branches covered (70.16%)

Branch coverage included in aggregate %.

962 of 1195 relevant lines covered (80.5%)

27.81 hits per line