aio-libs / multidict / 37203632573

86%

push

github

Drop inline from functions registered as slots or methods (#1672)

<!-- Thank you for your contribution! -->

## What do these changes do?

Drops `inline` from five C functions whose address goes into a slot or
method table: `multidict_tp_traverse`, `istr_tp_dealloc`, `istr_reduce`,
`istr_new` and `multidict_copy`. GCC has to emit an out-of-line copy of
each anyway. `multidict_tp_traverse` kept the keyword from #1589, when
it was still the `md_traverse()` helper behind a wrapper.

`md_clear` is also a slot but keeps `inline`: it has six direct callers,
and dropping the keyword changes the codegen of 53 functions on GIL and
166 on FT.

`tools/codegen_diff.py --ref f2d1da7b` reports no difference on 3.14.7
(GIL). On 3.14.7t (FT), the `multidict_tp_traverse` change alone shifts
GCC's inlining budget so that `bump_version` is now inlined into
`cimultidict_setdefault`; the other four are identical on both builds.
Callgrind on FT, `multidict_c` and `cimultidict_c` with
`--include-multidict-only`: one of 60 rows moved, `cimultidict_c
setdefault_new` 739.0 -> 737.0 Ir/op (-0.27%).

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist: N/A, no behavior change;
existing suite covers these slots
- [x] Documentation reflects the changes
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`: N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); to be reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests, each in its own venv and tree copy:
- 3.14.7t C extension: 4062 passed, 196 skipped
- 3.14.7 C extension: 4077 passed, 181 skipped
- 3.10.17 C... (continued)

792 of 1584 branches covered (50.0%)

Branch coverage included in aggregate %.

9315 of 10167 relevant lines covered (91.62%)

1.83 hits per line