zostera / django-icons / 37193956757

100%

push

github

Fix a shared variant pattern cache, and cover every branch (#662)

Coverage was 97%. Writing the tests for the gaps turned one of them up as a
bug rather than a hole.

_get_image_variant_attributes_regex cached the compiled patterns on a class
attribute and reached it through the MRO, so `cls._variant_attributes_regex`
found the parent's dict. The first renderer to compile decided the patterns
for every class in the process, and mutating the found dict wrote into the
parent. An ImageRenderer subclass that overrides
get_image_variant_attributes_pattern therefore had its patterns, defaults
included, silently ignored, depending on render order. In a long running
server that is order dependent behaviour across requests.

The cache is now per class, keyed on cls.__dict__ rather than attribute
lookup, and the class level declaration is gone because it would otherwise
satisfy that check and freeze an empty cache.

This was not theoretical: the new tests passed alone and failed in a full run,
which is what exposed it.

The remaining gaps were ordinary: variant attribute defaults applied from a
name, from a keyword argument and from neither; a variant with no default left
unset; and `content` in the ICONS settings given as one value, a list, and a
nested icon, which nothing covered.

fail_under = 100 matches the block django-marina and django-bootstrap5 carry,
comment included and byte-identical.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

56 of 56 branches covered (100.0%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

227 of 227 relevant lines covered (100.0%)

16.0 hits per line