bleedingdeacons / register / 37156541012

50%

push

github

fix: count a refused SMTP password towards the email circuit breaker (#53)

* refactor: split Register.Core out of the MAUI app

A test project cannot reference the app: its target frameworks are
platform heads, and there is no net10.0 head of a MAUI app. So nothing
but Unity.Intergroup has ever been testable. Register.Core is the plain
net10.0 half - attendance and compliance, the two event logs, snapshot
and reconcile, the email queue and its templates, the Freedom overlay -
which is the arrangement Link and Hand already use, and the precondition
for giving Register the same executable specification Link has.

Three seams, each the minimum that lets a file leave MAUI behind:

- The event logs take the path they write to. Where that is (Documents,
  falling back to AppDataDirectory) moved to EventLogDirectory in the
  app, one ladder for both logs as before.
- EmailService takes a network probe in place of Connectivity.Current,
  required rather than defaulted, and an optional SMTP client factory in
  place of four bare `new SmtpClient()`s.
- TemporaryIdGenerator persists through an ITemporaryIdStore handed to
  Use() at startup. The app's store keeps the old Preferences key, so a
  tablet upgraded mid-meeting resumes its count.

BuildInfo stays in the app because it reads the build stamp from its own
assembly. DayItem stays because it is a view model's item. The email
templates are embedded in Core beside the EmailTemplateService that reads
them; RootNamespace matches so the resource names did not change.

Core targets net10.0 plus net10.0-windows on Windows, mirroring
Unity.Intergroup, so the Windows head does not get two builds of one
assembly. Also adds Core and the existing Unity.Intergroup.Tests to the
solution.

* refactor: move the registration gate into Register.Core

The rules for whether a group or position may be registered, and whose
consent must be captured first, were written out in the two Verify view
models: the contact check four ti... (continued)

25 of 26 new or added lines in 1 file covered. (96.15%)

2113 of 4278 relevant lines covered (49.39%)

4.13 hits per line