coderaiser / happy-style / 37154279597

100%

push

github

Revert "chore: happy-style: actions: lint ☘️"

This reverts commit 02388f81b12.

The Lint job's `putout . --fix` rewrote working code into code that throws:

```js
-const isDeclaration = (node) => node.type === 'Declaration';
+const isDeclaration = isDeclaration;
```

Nine files, and every one is now a `const` bound to itself, which is a TDZ error
the moment the module loads:

```
$ npx tape 'lib/parser/visitors/atrule/atrule.spec.js'
ReferenceError: Cannot access 'isDeclaration' before initialization
```

`putout/apply-type-check` saw `node.type === 'Declaration'` and applied the fix
that `AGENTS.md` describes for `@putout/plugin-putout`'s rule of the same name:
rewrite the comparison to an `is*` helper. What it cannot know is that the
*helper it substituted* is the identifier being declared on that very line — so
the "fix" is `x = x`.

That is not a finding about this package, and the package is not the thing to
change: the rule picked a name that collides with the identifier it is about to
assign. Written up in putout-editor's `docs/issues/putout-plugins.md`, with the
repro.

Verified here: 206 tests pass at this commit, and the tree at 02388f8 throws on
import.

394 of 394 branches covered (100.0%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 12 files covered. (100.0%)

1789 of 1789 relevant lines covered (100.0%)

61.25 hits per line