aio-libs / multidict / 37149651226

86%

push

github

Pass the kind to htkeys_entry_size() and copy entries with a helper (#1660)

<!-- Thank you for your contribution! -->

## What do these changes do?

Folds `htkeys_kind_entry_size(kind)` into `htkeys_entry_size()`, which
now takes the kind instead of the table, so there is one entry size
helper rather than two. The two bulk `memcpy()` calls in `_md_rebuild()`
and `_md_rebuild_keeping_indices()` move into a new
`htkeys_entries_copy()` next to `htkeys_entry_copy()`, which leaves the
size helper used only inside `htkeys.h`, so it becomes
`_htkeys_entry_size()`. C extension only; the pure-Python backend has no
equivalent.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behavior change; covered
by the existing suite)
- [ ] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

The first commit alone is a codegen no-op: `tools/codegen_diff.py --ref
467f0964` reports 0 of 334 (3.14.7) and 0 of 348 (3.14.7t) functions
differing. The helper commit is not: about 14 functions in the resize
and merge/update paths change size by a few instructions, and GCC moves
which caller calls `_md_resize_for_add` out of line. The rest of the
reported functions differ only in shifted line-number immediates.

Callgrind (`benchmarks/callgrind_driver.py --include-multidict-only`,
`multidict_c` and `cimultidict_c`, PYTHONHASHSEED=0), base 467f0964 plus
the first commit, against the branch head: no row mov... (continued)

791 of 1582 branches covered (50.0%)

Branch coverage included in aggregate %.

9224 of 10068 relevant lines covered (91.62%)

1.83 hits per line