cenkalti / rain / 37149188682

51%

Build Type

push

github

Committed by cenkalti

Commit Message

lint: stop shadowing builtins, fix gofmt and else-flow

Go 1.21 made min, max and clear builtins, and nine locals still shadowed
them, so inside those functions the builtin was unreachable:

  stree.endpoints      named returns min, max -> lo, hi
  mse.readSync         parameter max          -> remaining
  metainfo.cleanNameN  parameter max          -> maxLen
  metainfo.trimName    parameter max          -> maxLen
  console.triggerUpdateDetails  parameter clear -> clearFirst

Two else branches followed an if that already returned or broke, so they
are outdented. In peerwriter.queueMessage the break leaves the switch
rather than a loop, which the restructure preserves and now says out
loud; its two paths are covered by the queue tests.

Also reformats parse_test.go, the one file gofmt flagged.

No behavior change. Found by running the Go Report Card check set
locally, since the service itself has shut down.

Coverage Stats

15 of 22 new or added lines in 6 files covered. (68.18%)

2 existing lines in 1 file now uncovered.

6115 of 12015 relevant lines covered (50.89%)

85.2 hits per line