cenkalti / rain / 37145289099

51%

Build Type

push

github

Committed by cenkalti

Commit Message

torrent: guard the two unlocked bitfield writes

mBitfield protects t.bitfield so Session.updateStats and the announcer can
read it off the run goroutine. Two of the four writes did not take it,
both on the verify path: handleVerifyCommand and handleStopped set the
field to nil bare, while handleVerificationDone and handleAllocationDone
lock around theirs.

Session.updateStats runs on a timer and again from Session.Close, so
closing a session while a torrent verified raced the read. Reproduced
under -race about one run in five, and only via the verify path, which is
why the download tests never caught it.

Adds the Start/Verify command test that exposed it.

Coverage Stats

2 of 4 new or added lines in 2 files covered. (50.0%)

82 existing lines in 6 files now uncovered.

5432 of 12016 relevant lines covered (45.21%)

82.5 hits per line