go-pkgz / syncs / 37140063376

99%

master: 99%

Pull #18

github

Skip queued callbacks in ErrSizedGroup after context cancellation

Cancellation was checked only on entry to Go, so callbacks already waiting
for a semaphore permit still ran after the group's context was canceled and
Wait returned nil. The check now also runs after the permit is acquired, in
both locking modes and with or without TermOnErr. The context error is
recorded once, running callbacks finish and keep their own errors.

TestErrorSizedGroup_CancelWithActiveErrors used to rely on queued callbacks
running after cancel. It now waits for all callbacks to start before canceling.

5 of 5 new or added lines in 2 files covered. (100.0%)

180 of 182 relevant lines covered (98.9%)

2096.29 hits per line