romshark / datapages / 37113737865

44%

push

github

fix: Serve only GET on {$} and wildcard pages

- fix: Refuse actions and an SSE stream on a page whose route ends
  in {$}, which now declares a page that serves only GET, and suggest
  removing the {$}. Every page is registered with {$} after its route,
  which left a {$} in the route comment with no effect but one: it
  refused actions below the page with a hint net/http rejects:

      // PageSettings is /settings/{$}
      type PageSettings struct{ App *App }

      func (PageSettings) OnSaved(e EventSaved, sse datapages.SSE) error

      // POSTSave is /settings/save
      func (PageSettings) POSTSave(r *http.Request) error

  datapages lint and gen accept OnSaved, and report POSTSave as not
  under its page with the suggestion /settings/{$}/save, a pattern
  net/http rejects. Without the {$}, the page keeps its URL.

- fix: Report each action of a page whose route ends in a {name...}
  wildcard with an error saying such a page cannot have actions,
  and suggest removing the wildcard, as for its stream:

      // PageFiles is /files/{rest...}
      type PageFiles struct{ App *App }

      func (PageFiles) POSTMove(r *http.Request) error

  datapages lint and gen suggest the path comment
  // POSTMove is /files/{rest...}/move, and with it report a route
  conflict on "POST /files/{rest...}/move/{$}", a pattern the app does
  not declare.

50 of 58 new or added lines in 3 files covered. (86.21%)

14771 of 36387 relevant lines covered (40.59%)

543.83 hits per line