albertito / chasquid / 37113635309

95%

main: 95%

Build Type

push

Committed by albertito

Commit Message

test: Use modern testing features instead of custom helpers

Many of our tests rely on helpers that predate features which are now
available in the standard library.

This patch replaces them with the standard equivalents:

- MustTempDir/RemoveIfOk -> t.ArtifactDir() or t.TempDir() (depending on
  whether it is useful to keep the data on request).
- GetFreePort + waitForServer -> opening the listeners before starting
  the servers. To support this, localrpc.Server gains a Serve method. We
  may re-introduce these in the future if more use cases appear.
- WaitFor and real-time timing checks -> testing/synctest.
- context.Background() -> t.Context().
- Benchmark b.N loops -> b.Loop().
- reflect.DeepEqual -> cmp.Diff, and proto.Equal for protobufs.

Coverage Stats

11 of 12 new or added lines in 2 files covered. (91.67%)

11 existing lines in 2 files now uncovered.

4875 of 5167 relevant lines covered (94.35%)

64845.14 hits per line