bleedingdeacons / register / 37092075669
92%
main: 50%

LAST BUILD BRANCH: ci/version-bump-race
DEFAULT BRANCH: main
Ran
Jobs 1
Files 22
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.963%. First build
37092075669

Pull #49

github

crazeydave 
refactor: move the registration gate into Register.Core

The rules for whether a group or position may be registered, and whose
consent must be captured first, were written out in the two Verify view
models: the contact check four times (UpdateCanRegister and CanExecuteYes
in each), the consent filter three (each Yes(), plus the inverted copy
over cascaded position holders), and the consent loop twice. Copies kept
in step by hand, and out of reach of any test host.

RegistrationGate (Core, static, no state) now holds the contact check,
the stand-in check, NeedingConsent, and the cascaded-holders lookup.
ConsentRound (Core) runs the per-member prompt: refuses with no cached
policy or an empty body, asks in order, stops at the first decline, and
records each acceptance as it is given, carrying on if a record fails.
The asking is handed in as a function, since the popup is MAUI.

ConsentPrompt (app) maps the round's outcome onto the existing popups,
so the two "Cannot record consent" messages are written once instead of
twice. Wording unchanged, fallback names ("this GSR", "this position
holder") unchanged.

No behaviour change intended. Two log lines lose their "aborting group /
position registration" suffix; the view model logs the abort itself
straight after, as it already did.
Pull Request #49: refactor: move the registration gate into Register.Core

698 of 759 relevant lines covered (91.96%)

5.18 hits per line

Jobs
ID Job ID Ran Files Coverage
1 37092075669.1 22
91.96
GitHub Action Run
Source Files on build 37092075669