openconfig / kne / 37062706426

48%

push

github

Bake container images directly into containerd and load into KinD via containerd archive (#777)

* Fix ineffective docker image caching

1. Removed redundant Docker pulls: Removed the old sudo docker pull ... block in the Docker installation step, which was
storing images in Docker's Moby engine store (/var/lib/docker/) where containerd / kubeadm could not see them.
2. Added containerd pre-pull provisioner (ctr -n k8s.io): Positioned right after containerd is configured and restarted,
pulling directly into the k8s.io CRI namespace.
3. Authenticated private GCP registry pulls: Pulls from us-west1-docker.pkg.dev using TOKEN=$(gcloud auth print-access-
token) via sudo ctr -n k8s.io images pull -u "oauth2accesstoken:$TOKEN" "$img".
4. Complete image coverage:
    • Core KNE & topology components (meshnet:ga, bridge:ga, init-wait:ga).
    • Vendor NOS images (ceos:ga, xrd:ga, 8000e:ga, ncptx:ga, srlinux:ga, lemming:ga).
    • CNI & Ingress (flannel, flannel-cni-plugin, kindnetd, metallb/controller, metallb/speaker).
    • Controllers & Operators (srl-controller, arista-ceoslab-operator, openconfig-lemming/release/operator, kube-rbac-
    proxy, keng-operator).
    • Keysight / OTG engine images (keng-controller, otg-gnmi-server, ixia-c-traffic-engine, ixia-c-protocol-engine).

* Have kind load from containerd by default rather than K8s

This allows it to share the same images stored for kubeadm use. If the
image isn't found that way fall back to the established docker pull
/ kind load method, to minimize the risk of breaking any existing
usages.

* Fix errcheck violations for temp file close and removal in deploy

* Fix escaping

* Can't use bash arrays

* More posix shell fixes

* Consolidate on a single instance of init-wait

* Parallelize image pulls and restore the auth configure

* un-export clusterKindNodes

* simplify dst != src case for containers going into kind

54 of 61 new or added lines in 1 file covered. (88.52%)

6869 of 14504 relevant lines covered (47.36%)

0.54 hits per line