kubeflow / mcp-server / 37048848947
83%

DEFAULT BRANCH: main
Ran
Jobs 3
Files 38
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 81.663% (+0.06%) from 81.608%
37048848947

push

github

web-flow 
fix(core): withhold the next hint on confirm gate previews (#296)

* fix(core): withhold the next hint on confirm gate previews

A mutating tool called with confirmed=False returns a preview and sends
nothing to the cluster, but _inject_meta still attached the next hint from
TOOL_NEXT_HINTS. Those hints describe the step after the action ran, so a
fine_tune preview told the caller to "Monitor with get_training_job(name)"
for a job that did not exist, and a delete_training_job preview said to
resubmit. All 8 mutating tools were affected.

Withhold next for previews the same way it is already withheld for blocked
results (#237). A preview is a PreviewResponse (status="preview") or, for the
three runtime tools, the legacy ToolResponse with data.action="preview". The
phase stays, since it is still accurate.

A "call again with confirmed=True" hint was considered instead and left out:
the confirm gate exists so a person approves the action, and the preview
message already explains how to confirm.

Fixes #295

Signed-off-by: Abhishek <abhikokadwar2@gmail.com>

* fix(core): limit the legacy preview shape to the runtime tools

_is_preview treated any response carrying data.action="preview" as a confirm
gate preview. Only create_runtime, patch_runtime and delete_runtime use that
shape, so a different tool returning the same field would have lost its next
hint for no reason.

Pass the tool name into the helper and accept the legacy shape only for those
three tools. status="preview" from PreviewResponse still counts for every tool.

Add a regression test that walks every tool with a hint and checks that
data.action="preview" leaves the hint in place outside the runtime tools.

Signed-off-by: Abhishek <abhikokadwar2@gmail.com>

---------

Signed-off-by: Abhishek <abhikokadwar2@gmail.com>

2445 of 2994 relevant lines covered (81.66%)

2.45 hits per line

Coverage Regressions

Lines Coverage ∆ File
23
90.07
0.34% core/server.py
Jobs
ID Job ID Ran Files Coverage
1 python-3.12 - 37048848947.1 38
81.66
GitHub Action Run
2 python-3.10 - 37048848947.2 38
81.66
GitHub Action Run
3 python-3.11 - 37048848947.3 38
81.66
GitHub Action Run
Source Files on build 37048848947