nebkat / flutter-bluebird / 37047222290

88%

push

github

feat: order GATT operations on the platform instead of in Dart

Every call used to pass through two global Dart mutexes, `Mutex.global`
for GATT operations and `Mutex.platform` for everything, so the next
operation could not reach the platform until the previous result had
come back to Dart's event loop. A busy UI stretched the gap between
operations, one device's operations waited on another's, and a call
given up on at its `timeout` left the native slot busy, so the next one
failed with `operationInProgress`.

Android and Darwin now queue each device's operations natively, so both
mutexes go and a call reaches the platform as soon as it is made; the
platforms' own `_restartFuture` still gates everything on the hot-restart
handshake. Connects stay one at a time across all devices
(`Mutex.connect`), since Android is unreliable when `connectGatt` calls
overlap. A queued `disconnect()` now waits for the calls already made to
that device, and its connect attempt, rather than for every device's.

Web has no native layer, and Chrome rejects a GATT operation started while
another is pending, so `bluebird_web` gets its own per-device queue.
Operations still waiting when the device disconnects fail with
`deviceDisconnected` instead of running on the next connection, and the
one running keeps the queue until it settles so the next connection's
operations never overlap it.

`Bluebird.invoke` runs the call inside `Future.sync`, so an unsupported
platform fails the returned future rather than throwing at the caller, as
it did while the mutex made the call asynchronous.

Requires the native queues from the two previous commits.

27 of 29 new or added lines in 4 files covered. (93.1%)

926 of 1056 relevant lines covered (87.69%)

4.79 hits per line