infernojs / inferno / 37033856716

95%

push

github

Converted rest of the test cases to typescript, closes https://github.com/infernojs/inferno/issues/1632

- createElement (inferno-create-element) now has three overloads:
  - DOM elements: ref receives the element.
  - Function and forwardRef components: also accept the lifecycle hook props.
  - Class components: ref receives the instance.

  The old signature typed every ref as receiving the props object. This also removed a TODO and two as any casts from createElement.spec.ts.
- Function-component lifecycle hooks (Refs<P> in inferno core) may now be null, which Inferno already handles at runtime. I kept their parameters bivariant like methods; making them strict broke the animation tests.
- Multi-select value now accepts number[].
- style: core now has a small registry of accepted style object types. inferno-compat adds camelCase/numeric styles and onDoubleClick to it. Plain Inferno users keep the strict hyphenated typing; the extra types only apply when inferno-compat's types are loaded.
- inferno-compat:
  - render<T>() and unstable_renderSubtreeIntoContainer<T>() are generic in the returned instance, like querySelector<T>(). The callback of the latter is now optional.
  - Children.* accept null, undefined or a single child, and ctx is optional. map now declares that it returns null/undefined for those inputs, as React's types do.
  - createFactory returns a properly typed factory.
  - PropTypes validators have isRequired, and shape()/arrayOf() etc. accept their arguments.
  - PureComponent has default type arguments.
- inferno-extras: findDOMNode() accepts any component instance, null and undefined.
- inferno-mobx:
  - inject() returns the actual injector type, now exported as InjectedComponent and IInjector, with wrappedComponent, the hoisted statics and wrappedInstance.
  - observerWrap accepts a typed context, typed like Inferno's own function components.
  - The observer(stores) decorator now returns the component instead of void.
- inferno-r... (continued)

3304 of 3793 branches covered (87.11%)

16 of 16 new or added lines in 3 files covered. (100.0%)

5186 of 5495 relevant lines covered (94.38%)

9644.74 hits per line