vbuch / node-signpdf / 37029479197

99%

master: 100%

push

github

🐛 extractSignature: read DER length instead of stripping trailing 00 pairs (#319)

The trailing-byte strip (replace(/(?:00|>)+$/)) cannot distinguish sign()'s
zero-padding from a genuine signature whose last byte(s) happen to be 0x00
(~1/256 chance per signature), so it intermittently truncated valid DER and
downstream parsers failed with "Too few bytes to read ASN.1 value."

Read the total element length from the DER SEQUENCE header instead; fall
back to the historical trailing-zero strip when the blob is not parseable
DER. Fixes #317.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

183 of 186 branches covered (98.39%)

Branch coverage included in aggregate %.

15 of 17 new or added lines in 1 file covered. (88.24%)

425 of 427 relevant lines covered (99.53%)

20.99 hits per line