letsencrypt / pebble / 36970480394

9%

master: 8%

Pull #564

github

Fix deadlock from taking db lock while holding authz lock in Authz()

Authz() held the authorization's write lock while it looked up the
account, which takes the MemoryStore read lock. FindValidAuthorization
takes the same two locks in the opposite order: it holds the MemoryStore
read lock while it read-locks every authorization. Once a writer such as
AddAccount queues on the MemoryStore lock, the three goroutines wait on
each other and every later request that touches the db hangs.

Authz() also read-locked the order while holding the authz lock, which
is the reverse of the order used by Order.GetStatus.

Do the order and account lookups before taking the authz lock.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Richard Wall <richard.wall@cyberark.com>

0 of 14 new or added lines in 1 file covered. (0.0%)

442 of 4665 relevant lines covered (9.47%)

1.71 hits per line