jellydator / ttlcache / 37007232020

100%

master: 100%

Pull #225

github

fix: prevent race condition between Start and Stop leaving expiry loop running

When Stop() was invoked concurrently with or immediately before go Start(),
Stop() observed c.stopped == true (its initial state from New()) and returned
immediately as a no-op without recording the stop request. When Start()
subsequently ran, it observed c.stopped == true, cleared c.stopped to false,
and entered its expiry loop indefinitely, leaking the goroutine and timer.

Track stopRequested under stopMu so that Stop() records the shutdown request
regardless of whether the loop has initialized, and Start() aborts immediately
if Stop() has already been called.

Fixes #224

3 of 3 new or added lines in 1 file covered. (100.0%)

777 of 779 relevant lines covered (99.74%)

49.34 hits per line