aio-libs / multidict / 37005918410

86%

push

github

Set empty_htkeys' kind explicitly (#1649)

<!-- Thank you for your contribution! -->

## What do these changes do?

The shared `empty_htkeys` table left `.kind` to zero initialization, so
it was `KIND_ANYSTR` only by accident. This sets it explicitly, with a
comment on why the value does not matter: the table has no entries to
lay out, and a table replacing it takes its kind from `md_next_kind()`,
which ignores the kind of a table with no entries. The value is
unchanged, so the generated code is the same. C extension only; the
pure-Python backend has no table kinds.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist: N/A, no behaviour change
- [ ] Documentation reflects the changes: N/A
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`: N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests: C extension built in place on 3.14.7t, `pytest tests`: 4001
passed, 41 skipped. Deselected
`test_circular_imports.py::test_no_warnings[multidict._testcyapi]`,
which runs `python -I` and so imported the shared pyenv's installed
multidict without `_testcyapi`; unrelated to this change. Pure-Python
leg not run (C-only change).
Inlining: `tools/check_inlining.py` on 3.14.7 and 3.14.7t: ok, 15 rules
each.
Docs: `make doc-spelling` passed.
</details>

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

791 of 1582 branches covered (50.0%)

Branch coverage included in aggregate %.

9127 of 9947 relevant lines covered (91.76%)

1.84 hits per line