decentraland / marketplace-server / 36946826385

71%

main: 70%

Build Type

Pull #433

github

Committed by LautaroPetaccio

Commit Message

refactor: rename trades list contract filter to marketplaceAddress

trades.contract holds the marketplace contract that settles the trade, so
`contract` read like a collection filter. Use `marketplaceAddress`, the name
GET /v1/orders already uses for the same column, and document it as the
marketplace contract the trade was signed for. Still repeatable, up to 100.

Also log list failures and return a generic 500 message instead of the raw
error, move the strict non-negative integer parser to logic/http, and cover
`first` alone and `skip` alone in unit and integration tests.

Pull Request Pull Request #433: feat: filter trades list by signer and marketplace address and paginate

Coverage Stats

2798 of 4407 branches covered (63.49%)

Branch coverage included in aggregate %.

57 of 71 new or added lines in 6 files covered. (80.28%)

66 existing lines in 3 files now uncovered.

4942 of 6544 relevant lines covered (75.52%)

6299.75 hits per line