NVIDIA / nodewright / 36890207969
83%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 59
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.002% (-0.2%) from 82.201%
36890207969

push

github

web-flow 
fix(operator): remove the global AGENT_IMAGE default so operator-agent-tests fails loudly (#706)

* fix(operator): scope the agentless AGENT_IMAGE default to make run

The global `AGENT_IMAGE?=$(IMG_REPO)/agentless:6.2.0` satisfied the
AGENT_IMAGE guard in operator-agent-tests, so invoking that target without
an agent image silently tested the agentless image instead of failing.

Move the fallback to a separate AGENT_IMAGE_DEFAULT that only the `run`
recipe consumes, leaving AGENT_IMAGE empty unless the caller sets it. A
target-specific `run: AGENT_IMAGE?=` was not used: declaring AGENT_IMAGE
target-specific stops make exporting a caller-supplied value to the
`$(MAKE) run` sub-make, which silently dropped it.

Signed-off-by: Alex Yuskauskas <ayuskauskas@nvidia.com>

* docs: correct the AGENT_IMAGE guard rationale in four places

Four sites said operator-agent-tests refuses to run because the Makefile's
global AGENT_IMAGE default is the agentless image. That is no longer the
reason: AGENT_IMAGE now has no global default at all, so the guard fires on
an empty value, while `make run` keeps a working fallback through a separate
AGENT_IMAGE_DEFAULT.

CONTRIBUTING.md and .claude/CLAUDE.md additionally claimed a bare `make test`
silently passes or skips the agent contract. It now fails at the guard with
"Error: AGENT_IMAGE is not set." -- the opposite of what they said. CI is
unaffected either way: it still resolves the pin from chart/values.yaml and
sets AGENT_IMAGE explicitly.

Signed-off-by: Alex Yuskauskas <ayuskauskas@nvidia.com>

* build: fail fast on missing AGENT_IMAGE and tighten docs

Move the AGENT_IMAGE guard out of the operator-agent-tests recipe into a
dedicated check-agent-image target and put it first in the `test::`
prerequisite list. A bare `make test` now aborts immediately instead of
after fmt/vet/lint and four kind-cluster e2e suites, which also meant the
second `test::` rule (merge-coverage plus the coverage report) never ran.
operator-... (continued)

9463 of 11540 relevant lines covered (82.0%)

7.62 hits per line

Coverage Regressions

Lines Coverage ∆ File
14
78.7
-0.45% operator/internal/controller/skyhook_controller.go
8
77.49
-2.28% operator/internal/cli/utils/utils.go
5
78.34
-3.18% operator/cmd/cli/app/lifecycle.go
Jobs
ID Job ID Ran Files Coverage
1 36890207969.1 59
82.0
GitHub Action Run
Source Files on build 36890207969