Kikobeats / isolated-function / 36890660747

97%

push

github

refactor: drop options nothing asks for (#88)

Audited every public option against its consumers: `@browserless/function`
and `nodepen`. Three had none.

`maxHostCalls` capped the number of distinct host calls a run could make.
Nothing ever set it, and the cap cannot bind on the only caller: every
host method the API exposes takes no arguments, so the key is one of
`content:[]`, `url:[]`, `metadata:[]` and the per-key memoisation already
collapses repeats into one call. That memoisation stays; only the cap is
gone.

Removing it exposed a mislabel: a non-serializable argument list rejected
with the budget message, which it never was. It now says what happened.

`shellCacheBytes` tuned the shell cache byte budget. Nothing set it, so
every caller got the default; the cache keeps it.

`__isolated_phase` recorded a duration a program asserted rather than one
it measured. Nothing used it except `__isolated_time`, which needs it
internally, so it is a local function now rather than a global. That also
narrows what untrusted snippet code can reach, which is the surface that
made the API's phase allowlist necessary.

One test compared `spawn` across two runs to show a span is not taken out
of it. That measures process boot, which moves under load, and it failed
in the parallel suite while passing alone. It asserts the relationship
within a single run instead.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

298 of 320 branches covered (93.13%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 3 files covered. (100.0%)

1252 of 1281 relevant lines covered (97.74%)

52.43 hits per line