urwid / urwid / 36883128028

91%

Build Type

push

github

Committed by web-flow

Commit Message

Fix the Windows console reader thread and input socket handling (#1379)

- A character outside the BMP arrives as two UTF-16 halves; encoding a
  lone half raised and silently ended the reader, losing all further
  input. Halves are now joined, also across reads, and a lone one is
  replaced.
- A failing ReadConsoleInputW was not checked, so the reader spun and
  re-sent stale records; a failed wait or read now ends it with a warning.
- The reader only noticed a stop request after the next console event, so
  stopping waited up to 5 s, dropped a batch, and the reader kept taking
  console input after the screen stopped. It now waits with a timeout and
  ends when the screen stops, not on every event loop re-hook.
- The input socket pair a screen creates is closed with the screen.
- A caller's input socket at end of file raises instead of spinning.
- ReadConsoleInputW has argtypes, input batches are sent with sendall, and
  a failed input mode change restores the output mode.

Coverage Stats

4550 of 5482 branches covered (83.0%)

Branch coverage included in aggregate %.

39 of 41 new or added lines in 2 files covered. (95.12%)

1 existing line in 1 file now uncovered.

11426 of 13053 relevant lines covered (87.54%)

9.78 hits per line