node-opcua / node-opcua-pki / 36880379501

92%

Build Type

push

github

Committed by erossignon

Commit Message

fix(certificate-manager): a late watcher unlink no longer drops a file written back

clearRevocationLists + addRevocationList writes the CRL back under the
same crl_[issuer].pem name and indexes it at once; the watcher's unlink
for the old file could be handled afterwards and remove it from the
index, so the issuer's certificates answered BadCertificateRevocationUnknown
until a later add event, or for good if none came. removeIssuer + addIssuer
and trusted/rejected round trips had the same shape for certificates.

Unlink handlers now check the disk: a file that exists again is re-read,
only a missing one is dropped. Re-reading a CRL replaces the entries from
that file instead of appending, and a CRL change event is no longer ignored.

Coverage Stats

706 of 924 branches covered (76.41%)

36 of 44 new or added lines in 1 file covered. (81.82%)

2 existing lines in 1 file now uncovered.

1922 of 2099 relevant lines covered (91.57%)

486.78 hits per line