kubeflow / trainer / 36870522487

72%

Build Type

push

github

Committed by web-flow

Commit Message

fix(api): Add missing update validation to Training Runtime webhook (#3687)

* fix(api): add webhook validation when updating namespaced TrainingRuntimes

The TrainingRuntime webhook is currently only validating namespaced runtimes on creation,
not on update, allowing invalid ReplicatedJob configurations to be applied during updates
even though they were caught on creation.

This change ensures update validation is consistent with create validation and matches the
validation for ClusterTrainingRuntimes.

Signed-off-by: Rob Bell <robell@redhat.com>

* fix: update integration tests so the runtime update is valid

Signed-off-by: Rob Bell <robell@redhat.com>

---------

Signed-off-by: Rob Bell <robell@redhat.com>

Coverage Stats

0 of 3 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

3341 of 4626 relevant lines covered (72.22%)

0.84 hits per line