ponder-lab / Hybridize-Functions-Refactoring / #3265

88%

push

github

Convert a hybrid function to eager only on an established absence (#1001)

* Keep a hybrid function whose scan meets an unresolved call

The hybrid-to-eager benefit precondition (P6) de-hybridized a function
whenever the tensor-op scan found no op. That absence is established
only if the scan saw every call: a call the call graph does not
resolve, such as a method on an object built through a factory the
analysis doesn't follow, may compute tensors the scan cannot see.
De-hybridizing such a function breaks one that relies on graph mode,
for example a training step whose gradients come from
`optimizer.get_gradients`, which returns `None` eagerly.

A "no tensor computation" verdict now records whether the scanned
bodies hold an unresolved call. When they do, P6 keeps the decorator,
as it does when the verdict is undetermined. A function with no
unresolved call still de-hybridizes, and the eager-to-hybrid side is
unchanged.

Part of #997: `translate.predict` is still converted, through the no-tensor-parameter rule (P2), not this one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Exempt builtins, and keep a function whose signature declares tensors

Exempt builtin calls from the unresolved-call check. Ariadne leaves many
Python builtins (`max`, `"{}".format`, `d.get`, `l.append`, `d.items`)
without a call-graph target, so counting them kept truly barren hybrid
functions. A call of a builtin by name, or of a method on a value that
points only to builtin strings, dictionaries, lists, tuples or sets, no
longer counts. Calling the result of `getattr` still does, and only
user code is inspected.

Keep a hybrid function that carries a supplied `input_signature` out of
every hybrid-to-eager rule (P2, P3 and P6). The signature declares and
enforces its parameters' tensor types, which overrides how the analysis
types them: an argument the analysis sees as a Python `int` becomes a... (continued)

148 of 152 new or added lines in 5 files covered. (97.37%)

4287 of 4923 relevant lines covered (87.08%)

0.87 hits per line