FlexMeasures / flexmeasures / 36852810680

86%

Build Type

push

github

Committed by web-flow

Commit Message

Feat: automation select data source (#2584)

* api/v3_0/sources: search the data sources listing, and narrow it to one type

Context:
- The listing returned every data source the caller may read, with no way to
  search it or to ask for one kind. A picker offering a choice of forecasters
  therefore had to fetch them all and sift through them in the browser.

Change:
- Add a `filter` of space-separated search terms, matched against a source's
  name, its model and its id prefix, the way the sensors listing already
  searches, and a `type`, which narrows the listing to one source type.
- Move the rule about which sources a user may read into the data-sources
  service, as `get_readable_source_account_ids` and `user_may_read_source`,
  so that it can be applied outside this endpoint without being restated.

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* api/v3_0/assets: let an automation name the data source it computes under

Context:
- A data source stores a data generator and the configuration it runs under, and
  the results computed under it are recorded on it. `flexmeasures add automation`
  has taken `--source` since the command was written, so several automations can
  share one generator and one lineage of data, but the API could only be handed a
  class and a config, which reaches an existing source by accident, when what it
  builds happens to hash to the same attributes.

Change:
- Accept a `source` on the creation endpoint, deserialized to the DataSource the
  service already knows how to take. It cannot be combined with `data-generator`
  or `config`, which the source itself determines, and a schedule automation
  cannot name one, since it re-resolves its source from the asset and the flex
  config on every run and would move off the named one at the next run.
- Require that the caller may read the source, by the same rule the sources
  listing applies. A source is otherwise a way to compute under, and record on,
 ... (continued)

Coverage Stats

88 of 89 new or added lines in 4 files covered. (98.88%)

1 existing line in 1 file now uncovered.

20783 of 24100 relevant lines covered (86.24%)

0.86 hits per line