comunica / traqula / 36850162146

100%

push

github

Fix unparseable HAVING and GROUP BY generation (#206)

For an AST without source locations, such as one translated from
algebra, the generator dropped the brackets around terms and prefix
operators in HAVING and GROUP BY: `HAVING (!BOUND(?o))` became
`HAVING ! BOUND( ?o )` and `GROUP BY (!?s)` became `GROUP BY ! ?s`.
The parser rejects both, as these positions only accept a call or a
bracketed expression (GROUP BY also accepts a variable).

The generator now brackets terms and the prefix operators `!` and
unary `+`/`-` in these positions. Infix operators need no change, as
`expression` already brackets them; comments in both places record
this dependency. Output for ASTs with source locations is unchanged.

The new fixtures having-brackets, group-by-prefix-operator and
sparql-1.1/aggregates/having-negation fail on main.

887 of 887 branches covered (100.0%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 1 file covered. (100.0%)

5906 of 5906 relevant lines covered (100.0%)

345420.53 hits per line