safe-global / safe-decoder-service / 36842707300

91%

push

github

fix: Reject oversized calldata and limit nested decoding depth (#355)

Nested execTransaction/MultiSend calldata was decoded recursively with no
depth limit. Every level keeps a hex copy of its inner payload, so memory
grows with the square of the payload size: 208 KB used 405 MB and ~830 KB
killed the process. py-evm raises the Python recursion limit to 100000, so
the recursion guard does not stop it, and the endpoint is public.

- DECODER_MAX_DATA_BYTES (default 131072, 128 KiB) caps `data` on
  POST /api/v1/data-decoder. Larger requests get a 422 before any decoding.
  Same value and style as API_MAX_TRANSACTION_DATA_BYTES in Safe Queue
  Service.
- DECODER_MAX_NESTED_DEPTH (default 8) caps nested decoding. Deeper inner
  data keeps its raw `value` and has no `value_decoded`, the same shape as
  inner data that cannot be decoded, so the response shape does not change.

Closes PLA-2045

5 of 5 new or added lines in 2 files covered. (100.0%)

1429 of 1569 relevant lines covered (91.08%)

0.91 hits per line