node-opcua / node-opcua / 36830665424

91%

Build Type

push

github

Committed by erossignon

Commit Message

fix(server-configuration): align TrustList Add/RemoveCertificate and GetRejectedList with Part 12

- AddCertificate/RemoveCertificate on a TrustList open for read answer
  Bad_NotWritable; Bad_InvalidState is kept for open with write access
  (OPC 10000-12 7.8.2.6, 7.8.2.7 result tables).
- RemoveCertificate decides Bad_CertificateChainIncomplete before touching
  the store, for both lists, and counts both lists as dependants: an
  intermediate CA in the Issuer list keeps its root, a trusted CA keeps the
  leaves it signs. A CA's CRLs now leave with it from the Trusted list too.
- ServerConfiguration.GetRejectedList returns the DefaultApplicationGroup's
  rejected certificates only (7.10.12: "a shortcut for" that group's method).

Removing first and re-adding on refusal left a window with no issuer.

Coverage Stats

24781 of 30035 branches covered (82.51%)

100 of 103 new or added lines in 4 files covered. (97.09%)

11 existing lines in 4 files now uncovered.

205477 of 223790 relevant lines covered (91.82%)

201819.78 hits per line