supabase / realtime / 36811496102

93%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: extract out presence related functions from realtimechannel (#2312)

* refactor: simplify presence event handling on channels

This moves some of the logic for when to do authorisation against the
database from RealtimeChannel to PresenceHandler.

Two side-effects of this:

1. We get to remove some duplicate code for presence error handling from
   RealtimeChannel.
2. We only need to create a database connection when we actually need to
   perform an authorisation check. Previously every track/untrack call
   on a private channel would call Connect.lookup_or_start_connection,
   which looks like it may involve some waiting. Now, private channels
   only need to get the connection the first time they attempt a write.
   This impact should be consistent with our "authorisation lasts until
   token refresh" promise.

* refactor: separates presence resync decision from action

Previously deciding whether to resync presence was handled by the
RealtimeChannel inspecting the before and after state of socket assigns,
and if a resync was needed it would queue one up. This change moves the
decision of whether to resync, enacapsulating the "why", into the
PresenceHandler. Now it just returns a value in the return tuple telling
the caller they should resync, which lets us remove some code from
RealtimeChannel.

* refactor: reuse PresenceHandler.can_read_presence?/1 in RealtimeChannel

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* refactor: use expect instead of stub

---------

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

Coverage Stats

19 of 20 new or added lines in 2 files covered. (95.0%)

3 existing lines in 2 files now uncovered.

4063 of 4413 relevant lines covered (92.07%)

4507.85 hits per line