NVIDIA / nodewright / 36780620192
83%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 59
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.14% (-0.3%) from 82.484%
36780620192

push

github

web-flow 
fix: surface drain blockers (PDB, unmanaged pods, emptyDir) as a DrainBlocked condition (#625)

* drain: block nodes with taint/ignore issues immediately; patch finalizer with optimistic lock; retry runtime-required taint removal

Signed-off-by: mohityadav8 <ymohit799057@gmail.com>

* fix: use exported wrapper.DrainBlockedNode instead of unexported nodeDrainBlock; fix test call sites for updated DrainNode/EnsureNodeIsReadyForInterrupt/ProcessInterrupt signatures

Signed-off-by: mohityadav8 <ymohit799057@gmail.com>

* fix: surface drain blockers (PDB, unmanaged pods, emptyDir) as a DrainBlocked condition

Signed-off-by: mohityadav8 <ymohit799057@gmail.com>

* fix: resolve merge conflicts with upstream/main; fix FormatNodeList casing and stale EnsureNodeIsReadyForInterrupt call sites

Signed-off-by: mohityadav8 <ymohit799057@gmail.com>

* fix: deduplicate blocked pods per node and render Detail fallback for unmanaged/emptyDir blockers

Signed-off-by: mohityadav8 <ymohit799057@gmail.com>

* fix: make DrainBlocked condition level-triggered off persisted per-node state

Signed-off-by: mohityadav8 <ymohit799057@gmail.com>

* fix: address ayuskauskas review round 2 on DrainBlocked condition

Signed-off-by: mohityadav8 <ymohit799057@gmail.com>

* refactor: reduce RunSkyhookPackages complexity; restore mock license headers

Signed-off-by: mohityadav8 <ymohit799057@gmail.com>

* fix: only persist DrainBlocked when DrainNode actually evaluated pods; clear stale annotations on every pass

Signed-off-by: mohityadav8 <ymohit799057@gmail.com>

---------

Signed-off-by: mohityadav8 <ymohit799057@gmail.com>
Co-authored-by: ayuskauskas <ayuskauskas@nvidia.com>

126 of 204 new or added lines in 5 files covered. (61.76%)

14 existing lines in 2 files now uncovered.

9479 of 11540 relevant lines covered (82.14%)

7.62 hits per line

Uncovered Changes

Lines Coverage ∆ File
47
79.42
-0.88% operator/internal/controller/skyhook_controller.go
13
87.16
-2.18% operator/internal/wrapper/node.go
11
93.53
-5.19% operator/internal/wrapper/skyhook_conditions.go
5
95.56
-0.33% operator/internal/controller/cluster_state_v2.go
2
96.23
-1.85% operator/internal/drain/drain.go

Coverage Regressions

Lines Coverage ∆ File
10
78.65
-5.21% operator/cmd/cli/app/package/package_logs.go
4
79.42
-0.88% operator/internal/controller/skyhook_controller.go
Jobs
ID Job ID Ran Files Coverage
1 36780620192.1 59
82.14
GitHub Action Run
Source Files on build 36780620192