solidjs / solid / 36762847598

76%

main: 89%

push

github

web: binding-slot text positions (#3714)

A binding-slot stand-in placed as a child (`<strong>{list.remaining}</strong>`)
rendered nothing and raised a `text` finding. Now a child is a text
position the client owns, like an attribute value. The server emits
`<!--_s:t=<occurrence>:<key>-->text<!--/_s:t-->`, with the escaped t=0
value on the document face and nothing on the stream face, from both
`resolveSSRNode` and `tryResolveString`. `collectSlots` registers each
pair on its parent element's existing consumer entry for the occurrence.
The occurrence's render effect writes the text node between the markers,
and `reconcileChildren` keeps a matching pair's interior across a
refetch. `<textarea>`, `<title>`, `<style>` and `<script>` content is
never a text position.

Public API changes:
- A binding-slot value placed as a child renders and binds (it rendered
  nothing).
- Diagnostic reason `text` retired, `text-shape` added
  (`BINDING_SLOT_POSITION`, client).
- New wire markers `<!--_s:t=<occurrence>:<key>-->` / `<!--/_s:t-->`.

Size-Exception (vetted by the maintainer; the base moved under the PR),
against next @ ecb68a18e:
- page: base server components: 46.04 -> 46.20 KB (46,193 B, +259 B)
- page: live server components: 50.17 -> 50.45 KB (50,442 B, +317 B)
- server: renderToString: 20.36 -> 20.38 KB (20,372 B, +16 B)
- frames eager client (not frozen): 12.71 -> 12.98 KB (12,963 B, +269 B)

649 of 925 branches covered (70.16%)

Branch coverage included in aggregate %.

962 of 1195 relevant lines covered (80.5%)

27.81 hits per line