decentraland / marketplace / 36751025656

67%

push

github

feat: deploy through the cdn-deploy action instead of the npm relay (#2728)

* feat: deploy through the cdn-deploy action instead of the npm relay

Deploying went through four hops: oddish published the built `webapp/dist` to
npm, that triggered a GitLab pipeline, the pipeline uploaded the tarball to the
CDN bucket, and a `deployment_status` webhook fired `set-rollout` to write the
Cloudflare KV record. Every hop needed a credential in this repository, and a
failure in the middle left the site on the previous version with a green run.

`cdn-deploy` does the whole thing in one step: it settles the version, runs the
build, uploads to S3 and writes the rollout through a broker that authenticates
this repository by GitHub OIDC. The broker checks `decentraland/definitions` to
confirm this repository owns `@dcl/marketplace-site` before it will write
anything, so no Cloudflare token and no IAM role live here any more.

Behaviour is preserved. A push to master still rolls out to zone and today at
100%, which is what the two steps in `set-rollout` did.

This app's layout needs two things spelled out. The action writes the settled
version into the repo-root `package.json`, but the build runs in `webapp/` and
`webapp/scripts/prebuild.cjs` reads `webapp/package.json` to derive
`VITE_BASE_URL`; the build command carries the version across through
`CDN_DEPLOY_VERSION` before invoking the build. And `package-name` is passed
explicitly, because the root manifest is called `marketplace` rather than the
package definitions binds to this repository -- left implicit, every upload
would land under a prefix the CDN does not serve.

The corepack step goes with the publish. It existed to reach npm CLI 11.5.1 for
Trusted Publishing, and nothing here publishes to npm now.

`set-rollout-manual.yaml` stays: it can set a version to 0%, which the new
`promote` job cannot express, and that is what a real rollback needs.

* fix: give each deploy path its own concurrency group

One g... (continued)

4450 of 8255 branches covered (53.91%)

Branch coverage included in aggregate %.

9748 of 12854 relevant lines covered (75.84%)

110.37 hits per line