penguinolog / urwid / 36748835020

86%

master: 74%

push

github

Fix ListBox focus restore on a shrunk body

ListBox.set_focus() records the old focus position, and the next
render restores it temporarily to scroll from it. When the body was
emptied or truncated in between, that position is gone and the walker
raises IndexError:

- SimpleListWalker on an emptied body.
- SimpleListWalker and SimpleFocusListWalker on a body truncated past
  the old position.

_set_focus_complete now keeps the new focus and goes on to place it,
so coming_from applies as it does for a focus that was not visible.
An empty body stops at the existing empty-view guard.
An error a "modified" signal callback raises during the restore still
propagates.

4508 of 5466 branches covered (82.47%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

11328 of 13015 relevant lines covered (87.04%)

9.73 hits per line