enbility / eebus-go / 36748033431

93%

Build Type

push

github

Committed by web-flow

Commit Message

Persist full-list writes to the remote feature cache (#261)

Follow-up to https://github.com/enbility/eebus-go/pull/253

## Problem

Remotes that announce a list function as writeable without `partial`
support receive the complete list on every write.
`LoadControl.WriteLimitData` and `DeviceConfiguration.WriteKeyValues`
build that list by merging the new entries into the locally cached
remote data (`UpdateData(persist=false)`), but the cache itself is only
updated once the remote notifies the change, which happens after the
result.

A second write built in between, e.g. OPEV obligation limits followed by
OSCEV recommendation limits, therefore merges into the stale cache and
reverts the entries of the first write. On the Porsche PMCC this leaves
the obligation limits inactive after every write; a disable (0.1A
obligation) ends with all limits inactive and the EV charging at
maximum. See evcc-io/evcc#34004 and evcc-io/evcc#34066 for traces.

## Fix

`Feature.writeFullList` sends the write and persists the merged list as
the remote feature's state right away. If the remote rejects the write,
the response callback restores the previous state. Partial writes are
unchanged.

## Test

`Test_WriteLimitValues_Persist`: after a full write the cache reflects
the written limit while other entries are kept, and an error result
restores the previous state. Fails on `dev` without the change.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Coverage Stats

17 of 21 new or added lines in 3 files covered. (80.95%)

7 existing lines in 1 file now uncovered.

9270 of 9999 relevant lines covered (92.71%)

13.95 hits per line