infernojs / inferno / 36720513081

95%

Build Type

push

github

Committed by web-flow

Commit Message

Renew inferno animations (#1702)

Inferno core
Move hooks moved out of the reconciler

On master, the reconciler drove move animations directly. In the LIS phase, moveVNodeDOM walked down to the DOM node looking for a componentWillMove/onComponentWillMove owner. If it found one, it didn't insert the node yet; it queued a MoveQueueItem. At the end, callAllMoveAnimationHooks ran the hooks and then did the postponed inserts. This had three problems:

Hooks fired only for nodes that were physically moved, not for the neighbours they pushed aside.
Hooks ran after the list had already been partly changed.
Animated moves happened in a different order from plain moves (the old TODO: Should we delay this too…).
Now the core only has a small hook-in point, MoveAnimationAdapter in DOM/utils/common.ts, held in two module variables:

moveAnimations: set when inferno-animation is installed, through the new _MA export (setMoveAnimations).
activeMoveAnimations: set only while at least one component with a move hook is mounted.
The reconciler reaches the adapter from these places, each guarded by a null check:

Mount and unmount report which components have move hooks: mountClass/unmountClass for classes (checked again after componentDidMount), and updateHooks for function components, including through updateMoveHooks when a patch adds a hook.

moveVNodeDOM now only calls insertOrAppend, so animated and plain nodes move in the same order. If no bundled code calls _MA, the bundler drops all the checks and the reconciler is the same as master's. The published core grew from 8,212 to 8,435 bytes brotli.

What changes for users:

componentWillMove is now called for every item a keyed update keeps, before anything is patched, not only for moved items. The tests in animationHooks.spec.tsx now expect 4, 6 and 8 calls instead of 3, 4 and 7.
Custom move hooks only run if the app has done import 'inferno-animation'. Without that import they are never called.
Appear and leave ho... (continued)

Coverage Stats

3179 of 3685 branches covered (86.27%)

1147 of 1243 new or added lines in 13 files covered. (92.28%)

4 existing lines in 2 files now uncovered.

5081 of 5404 relevant lines covered (94.02%)

9770.42 hits per line