bitshifter / glam-rs / 36705709108

99%

push

github

refactor(euler): inline Mat4/Quat euler extraction (#885)

# Objective

The `ToEuler` impls for `Mat4` and `Quat` only converted to `Mat3` and
delegated, putting an extra layer between the public `to_euler` methods
and the conversion.

## Solution

- `Mat4::to_euler` calls
`Mat3::from_mat4(*self).to_euler_angles(order)`.
- `Quat::to_euler` calls `Mat3::from_quat(self).to_euler_angles(order)`.
- The `ToEuler` impls for `Mat4` and `Quat` are removed.
- `ToEuler::to_euler_angles` no longer has `#[track_caller]`; the
extraction never panics.

10 of 10 new or added lines in 10 files covered. (100.0%)

93458 of 94358 relevant lines covered (99.05%)

122870.73 hits per line