safe-global / safe-client-gateway / 36699271682

89%

Build Type

push

github

Committed by web-flow

Commit Message

feat(billing): remove the given Safes before changing the plan (#3529)

PATCH /v1/billing/spaces/:spaceId/subscriptions/:subscriptionId takes an optional `removedSafes` list. The service removes those Safes with the existing SpaceSafesRepository.delete (a 404 because they are already gone counts as done), runs the existing seat check on what is left, then changes the plan in Stripe. The web app used to send the removal as a separate request first, and after step-up only the rejected request was replayed, so the Safes were removed and the plan never changed (WA-3706).

If the plan change fails after a request that carried `removedSafes`, the service logs it and answers 502 telling the caller to try again; sending the same request again takes the normal path. The removal is kept in its own helpers so it can be taken out of updateSubscription without touching the rest.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Coverage Stats

4505 of 5293 branches covered (85.11%)

Branch coverage included in aggregate %.

21 of 21 new or added lines in 3 files covered. (100.0%)

1 existing line in 1 file now uncovered.

11500 of 12616 relevant lines covered (91.15%)

545.47 hits per line