stacklok / toolhive / 36693427432
71%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 940
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 70.91% (+0.005%) from 70.905%
36693427432

push

github

web-flow 
fix(operator): allow multiple keys of one Secret in spec.secrets (#6690)

* fix(operator): allow multiple keys of one Secret in spec.secrets

SecretRef entries are per-key -- name and key are both required -- and the
env builder maps each entry to its own secretKeyRef, so referencing two
keys of the same Secret is expected usage. The list was keyed on name
only, so the API server rejected the second entry as a duplicate.

Fixes #6686

Signed-off-by: lights <115397533+lightsabit@users.noreply.github.com>

* ci: retrigger — the previous run failed downloading CI tooling, not from the change

* test(operator): admission regression test for spec.secrets (name, key) list-map keys

envtest suite installing the chart-shipped MCPServer CRDs and driving the
#6686 shape through API admission: two entries referencing different keys
of the same Secret are admitted (create and server-side apply, v1beta1 and
v1alpha1) and stored as two entries, while an exact (name, key) duplicate
is still rejected. Against the unpatched CRDs the two-key cases fail with
the #6686 error, so the suite guards the regression it was written for.

* test(operator): satisfy paralleltest and SA1019 in secrets admission suite

t.Parallel in every test scope, per the paralleltest linter. The three
server-side-apply calls keep the deprecated client.Apply patch constant
under a scoped //nolint:staticcheck — the new Client.Apply API requires
generated ApplyConfiguration types, which this repo does not generate,
so the typed patch path is the only way to exercise SSA here.

* ci: retrigger after known vmcp forwarding flake

TestForwarding_Logging_RealBackend timed out under CI load — the exact
flake tracked upstream in #5962 (same failure mode, previously deflaked
in #5963). Passes locally on this head; no code change, empty commit to
re-run the failed jobs.

---------

Signed-off-by: lights <115397533+lightsabit@users.noreply.github.com>
Co-authored-by: Sanskar Gurdasani <92817635+Sanskarzz@use... (continued)

84611 of 119321 relevant lines covered (70.91%)

126.03 hits per line

Coverage Regressions

Lines Coverage ∆ File
6
72.34
-6.38% pkg/secrets/keyring/keyctl_linux.go
3
82.38
-0.18% pkg/authserver/storage/redis.go
1
94.49
-0.79% pkg/vmcp/composer/dag_executor.go
Jobs
ID Job ID Ran Files Coverage
1 36693427432.1 940
70.91
GitHub Action Run
Source Files on build 36693427432