stripe / smokescreen / 36693674511

63%

push

github

Fix README badge, vendor check gap, and add a lint job (#334)

* all: fix gofmt and staticcheck findings

Clears the existing findings so a lint job can gate new ones: gofmt on four files, io/ioutil replaced with io and os, lowercase error strings, and small cleanups in the metrics mock. The only user-visible change is the capitalization of a few error messages.

The deprecated x509.ParseCRL and CheckCRLSignature calls are suppressed rather than migrated because Config.CrlByAuthorityKeyId exposes *pkix.CertificateList; moving to x509.RevocationList changes public API and belongs in its own change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Committed-By-Agent: claude

* ci: add lint job and catch uncommitted vendor files

The new Lint job runs gofmt and staticcheck across the default, integration, and no-Prometheus build tags, so formatting drift and deprecated APIs fail PRs instead of accumulating.

The vendor check used git diff, which ignores untracked files, so a dependency newly vendored by go mod vendor but never committed passed. It now fails on any porcelain status. The README Test badge moves to the workflow-file URL; the name-based URL it used renders as no status.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Committed-By-Agent: claude

* ci: fix lint and vendor failures on Go 1.27

staticcheck 2026.1 cannot read Go 1.27 export data and fails with internal import errors, so the Lint job now pins v0.8.1 (2026.1.1), which supports it.

The stricter vendor check caught drift: go mod vendor emits urfave/cli's CODE_OF_CONDUCT.md, which was never committed after #327. The file contains a contact email that Stripe's commit PII scanner rejects, so it is gitignored rather than committed; it has no effect on the build.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Committed-By-Agent: claude

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

6 of 13 new or added lines in 5 files covered. (46.15%)

1872 of 2894 relevant lines covered (64.69%)

14.71 hits per line