• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

LFDT-Panurus / panurus / 36692392983
85%

Build:
DEFAULT BRANCH: main
Ran 30 Sep 2026 09:00AM UTC
Jobs 0
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
36692392983

push

github

Effi-S
fix(storage): close db/sql postgres and sqlite findings from #2043

A batch of medium/low findings in token/services/storage/db/sql. Item 1 of the
issue, the token-lock Cleanup join divergence, was already fixed on main by
#2018 and needed no work here.

Postgres notifier: no lost-notification window on startup. pgxlisten calls
HandleBacklog only after it has issued LISTEN, so notificationHandler now
implements pgxlisten.BacklogHandler and uses it to report that the channel is
live. The first Subscribe waits for that instead of sleeping a blind 100ms,
which had nothing to do with whether the channel existed: a row written
straight afterwards could be emitted before LISTEN registered, and Postgres
discards a NOTIFY nobody is listening for. The real-Postgres test now asserts a
single insert is delivered, replacing the retry-insert loop that put the race on
the record. A readiness wait that times out still returns nil - the listener
keeps retrying, and failing the subscription would be worse than a late one - so
the godoc says that the delivery guarantee holds once the wait succeeds rather
than for every nil return.

Fixing that surfaced a latent panic, since waiting for LISTEN widens the window
from 100ms to seconds: Close could Wait() on listenerWg before Subscribe had
registered the listener goroutine - a counter raised from zero concurrently with
Wait - return early, and close listenerErr while the listener could still send
on it. The goroutine is now launched under mu, Close marks the notifier closed
under the same lock before waiting, and both the close and the error repost
happen under that lock. Reading nil off that closed channel reports an
ErrNotifierClosed sentinel, which the closed-notifier errors Subscribe returns
share, so a closed notifier can never be mistaken for a successful subscription
and callers can match with errors.Is instead of comparing strings.

Notifier dispatch: documented that callbacks run inline on the single listener
goro... (continued)
Source Files on build 36692392983
Detailed source file information is not available for this build.
  • Back to Repo
  • Github Actions Build #36692392983
  • 33a5e973 on github
  • Prev Build on main (#36674900936)
  • Next Build on main (#36735360451)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc