hyperledger / fabric-x-common / 36688058452
82%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 199
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.029%. Remained the same
36688058452

push

github

web-flow 
[dependency] Migrate to hyperledger/SmartBFT (#201)

#### Type of change

- Dependency update
- Bug fix

#### Description

- Replace `github.com/hyperledger-labs/SmartBFT` v1.0.1 with its new
home
`github.com/hyperledger/SmartBFT` v1.0.2, and bump testify, yaml, x/sync
and
  `google.golang.org/protobuf` (v1.36.11 -> v1.36.12).
- Regenerate all `*.pb.go` files; only the `protoc-gen-go` version
header changes.
- `make proto` no longer depends on the host setup:
- fetch the well-known types (`google/protobuf/*.proto`) matching the
installed
protoc into `.build/`, instead of relying on `/usr/include` from
`libprotobuf-dev`
    (which is unavailable on non-Debian hosts, e.g. RHEL);
- run `protoc-gen-go`/`protoc-gen-go-grpc` from the `go.mod` tool
directives via
    `go tool`, instead of whatever is in `PATH`.
- `make mocks` puts the `go.mod` versions of `counterfeiter`,
`protoc-gen-go` and
`protoc-gen-go-grpc` first in `PATH`, so `go generate` output matches
`make proto`.
- `make lint-proto` runs `api-linter` via `go tool`.
- Drop `libprotobuf-dev` from `scripts/install-dev-dependencies.sh`.

#### Additional details (Optional)

Verified in a clean Ubuntu 24.04 container by replaying the CI lint step
(`make proto`, `make mocks`, `git diff --exit-code`): no diff. Also
verified on RHEL 9.

#### Related issues

- resolves #200

---------

Signed-off-by: Yoav Tock <TOCK@il.ibm.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

13675 of 16671 relevant lines covered (82.03%)

0.82 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
95.71
-0.86% common/deliverclient/blocksprovider/bft_deliverer.go
1
86.36
0.0% common/channelconfig/bundle.go
Jobs
ID Job ID Ran Files Coverage
1 36688058452.1 199
82.03
GitHub Action Run
Source Files on build 36688058452