tari-project / tari / 36681473458

71%

Build Type

push

github

Committed by web-flow

Commit Message

chore!: remove validator eviction from the base layer (#8062)

Description
---
Ootle no longer implements validator eviction, so this removes it from
the base layer. It will ship with a testnet reset, so there is no
backward compatibility on the Ootle side.

Removed:
- `tari_sidechain`: `EvictionProof`, `EvictNodeAtom`, the
`Command::EvictNode` variant, and the eviction proof fixture/tests.
- `SideChainFeatureData::EvictionProof`,
`SideChainFeature::eviction_proof()` and
`OutputFeatures::for_validator_node_eviction`.
- Eviction validation (`check_eviction_proof` and the partial-validator
epoch check), their `ValidationError` variants, the LMDB insert/rollback
handling, and the backend methods only it used
(`validator_node_is_active_for_shard_group`,
`validator_nodes_count_for_shard_group`,
`ValidatorNodeStore::count_active_validators`).
- The P2P proto and gRPC encodings of the eviction proof, including the
sidechain block / commit-proof / QC messages that were only reachable
through it. Field `4` of the `SideChainFeature` oneof is reserved in
both protos.
- The wallet `SubmitValidatorEvictionProof` gRPC method and the
transaction-service request behind it.
- The node gRPC tests for "unknown sidechain network byte". No output
feature carries a sidechain block header anymore. The round-trip test
now uses a validator node exit feature.

Motivation and Context
---
Eviction output types are not used on any live network and Ootle has
dropped the feature.

Consensus safety on live networks
---
`SideChainFeatureData::ValidatorNodeExit` moves from Borsh/bincode
variant index 4 to 3. This cannot affect a live network:

- Both exits (`check_validator_node_exit`) and evictions (the removed
`check_eviction_proof`) require an active validator node. An eviction
additionally required a non-empty committee and a quorum signed by
active VNs.
- Every live network (mainnet, nextnet, stagenet, esmeralda) sets
`vn_registration_max_vns_per_epoch = 0` and
`vn_registration_m... (continued)

Coverage Stats

58 of 58 new or added lines in 2 files covered. (100.0%)

560 existing lines in 22 files now uncovered.

101794 of 145876 relevant lines covered (69.78%)

399111.5 hits per line