Eyevinn / moqlivemock / 36672802962

56%

Build Type

push

github

Committed by tobbee

Commit Message

fix(webtransport): advertise the initial stream and data limits, so Safari can open streams

In Safari, MOQ Player connected, received the server's control stream and then stopped: createUnidirectionalStream() never resolved, so the MoQ SETUP was never sent, the session was never established and no namespaces were listed. There was no error on either side.

Safari enforces WebTransport flow control, and reads a missing SETTINGS_WT_INITIAL_MAX_STREAMS_UNI, _BIDI or _MAX_DATA as zero, so it could open no stream at all. Chromium enforces only the limits the server sent, which is why it was unaffected. webtransport-go sends these settings only when Server.Config sets them, and replenishes them with WT_MAX_STREAMS and WT_MAX_DATA capsules as they are used; mlmpub and mlmrel left Config nil. Its v0.11.0 base sent them from ConfigureHTTP3Server, so this broke with the bump to the v0.12.0 fork in 170a61c, released in v0.13.0.

The server now allows 1000 concurrent bidirectional streams, 100 unidirectional streams and 16 MiB of data from the client, raised as they are used. TestWebTransportAdvertisesStreamLimits reads the server's HTTP/3 SETTINGS and fails without the change. Verified with Playwright's WebKit (Safari 26.6 engine) against a local mlmpub: without the change it stalls as in Safari; with it the session is established and CMAF video and subtitles play, with all subtitle tracks received side by side, and Chromium plays as before.

Coverage Stats

12 of 12 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

3402 of 6072 relevant lines covered (56.03%)

1262.46 hits per line