facebookincubator / TTPForge / 36640056508

53%

main: 67%

Pull #643

github

Forward named environment variables to remote steps (#643)

Summary:

## Context
- Remote commands do not inherit the runner's environment. Callers need to forward selected values, such as run identifiers, across SSH without editing each TTP.
- Forwarding is requested through a CLI flag so an older binary rejects unsupported usage before executing the TTP.
- GitHub CI exposed an existing Go version mismatch: `new("baz")` in `pkg/args/choices_test.go` requires Go 1.26, while the module selected Go 1.25.5.
## This Diff
- Add repeatable `--forward-env NAME` for remote `inline:` and `file:` commands.
- Trim and deduplicate names in argument order. Require nonempty names to match `[A-Za-z_][A-Za-z0-9_]*`; reject invalid names before remote command dispatch, even if unset. Skip unset variables; retain set-but-empty values on supported remote shells.
- Pass forwarded values literally, including `$forge.` references. Continue expanding TTP-level and step-level `env`, with forwarded < TTP < step precedence.
- Document the CLI interface, version requirement, validation, and precedence in the remote execution guide and schema reference.
- Cover forwarding and precedence with 14 authenticated loopback SSH cases, 12 invalid-name helper cases, and 6 executor rejection cases across POSIX, PowerShell, and cmd configurations.
- Set the module minimum to Go 1.26.0 and select Go 1.26.5. Have GitHub pre-commit derive its Go version from `go.mod`.
- Validate forwarded, TTP-level, and step-level environment names on every SSH shell backend before opening a command session.
- Quote `cmd.exe` environment assignments so operators and trailing spaces remain literal. Reject values that cmd cannot safely preserve (empty strings, double quotes, `%`, `!`, and ASCII controls); errors omit values.

Reviewed By: d0n601

Differential Revision: D120420789

58 of 70 new or added lines in 4 files covered. (82.86%)

3318 of 6243 relevant lines covered (53.15%)

15.67 hits per line